-
Notifications
You must be signed in to change notification settings - Fork 1.1k
KTOR-8200 fix + encoding on appendPathSegments #4738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes update how URLs are processed by removing the Changes
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (2)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please look into fixing these tests? It looks like it might just be a case of bad assertions, unless if you find some reason that they ought to expect the previous behaviour.
https://ktor.teamcity.com/buildConfiguration/Ktor_KtorMatrixCoreLinuxJava21/325088
Subsystem
ktor-http
Motivation
KTOR-8200
Solution
Removed the '+' character from VALID_PATH_PART.